Respect dynamic logging level changes for LevelSwitch section #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skomis-mm
changed the title
added 2 commits
January 5, 2019 04:50
- fine-tune ReloadDelay for the DynamicLevelChangeTests
|
Need some investigation why test on Travis / Linux fails. Probably should change file based notifications in the test to something more stable. |
- fixed failing test
|
Ok, ready for review when someone have a time :) |
tsimbalar
reviewed
Jan 7, 2019
| Assert.Single(DummyConsoleSink.Emitted); | ||
| } | ||
|
|
||
| void UpdateConfig(LogEventLevel? minimumLevel = null, LogEventLevel? switchLevel = null, LogEventLevel? overrideLevel = null) |
There was a problem hiding this comment.
Maybe that's personal taste, but I think turning the UpdateConfig Local Function into a proper method would make it clearer (and shorten the code in the test method)
tsimbalar
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LevelSwitchsectionDummyConsoleSinkFixes #99