New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure that single-file apps can find assemblies that contains sinks #353
Merged
nblumhardt
merged 13 commits into
serilog:dev
from
0xced:single-app-no-assemblies-exception
May 5, 2023
Merged
Make sure that single-file apps can find assemblies that contains sinks #353
nblumhardt
merged 13 commits into
serilog:dev
from
0xced:single-app-no-assemblies-exception
May 5, 2023
Commits on Mar 27, 2023
-
Make sure that single-file apps can find assemblies that contains sinks
Before this commit, when single-file app was detected, the behaviour was to fallback on DLL scanning. But DLL scanning would not find anything for an app published as a single-file, by sheer definition of single-file app! After this commit, an exception is thrown if the app is published as a single-file AND no `Serilog:Using` section is defined in the configuration. The error message explains that either a `Serilog:Using` section must be added or show how to explicitly configure assemblies through the `ConfigurationReaderOptions`.
Configuration menu - View commit details
-
Copy full SHA for e8b2a39 - Browse repository at this point
Copy the full SHA e8b2a39View commit details -
Configuration menu - View commit details
-
Copy full SHA for ecddb13 - Browse repository at this point
Copy the full SHA ecddb13View commit details -
Configuration menu - View commit details
-
Copy full SHA for a812ab1 - Browse repository at this point
Copy the full SHA a812ab1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a28018 - Browse repository at this point
Copy the full SHA 9a28018View commit details -
Run tests on the TestApp when published as self-contained
This is when the default DependencyContext is actually null. Also run all the tests on .NET 6 which is a Long Term Support (LTS) release.
Configuration menu - View commit details
-
Copy full SHA for 92d37fc - Browse repository at this point
Copy the full SHA 92d37fcView commit details -
Use a HashSet instead of a Dictionary keyed by the assembly full name. If an assembly is loaded twice with the same AssemblyName it will be the same instance so a HashSet (without even a custom IEqualityComparer<Assembly>) is the perfect solution. Also, Assembly.Load can throw many exceptions but won't return null.
Configuration menu - View commit details
-
Copy full SHA for 74402f8 - Browse repository at this point
Copy the full SHA 74402f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b6c040 - Browse repository at this point
Copy the full SHA 2b6c040View commit details -
Configuration menu - View commit details
-
Copy full SHA for e71c549 - Browse repository at this point
Copy the full SHA e71c549View commit details -
Use a nuget.config file instead of specifying multiple sources on the…
… command line This works around dotnet/sdk#27202 It also has the benefit of using settings _only_ from the specified config file, ignoring the global nuget.config where package source mapping could interfere with the local source.
Configuration menu - View commit details
-
Copy full SHA for 4828123 - Browse repository at this point
Copy the full SHA 4828123View commit details
Commits on Apr 2, 2023
-
Add a new PublishAsync(PublishMode) method and also add a comment explaining why it would not work to publish multiple apps in parallel.
Configuration menu - View commit details
-
Copy full SHA for 2cb45f5 - Browse repository at this point
Copy the full SHA 2cb45f5View commit details
Commits on Apr 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 895f83d - Browse repository at this point
Copy the full SHA 895f83dView commit details
Commits on May 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ac1b8c8 - Browse repository at this point
Copy the full SHA ac1b8c8View commit details
Commits on May 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e87d4e8 - Browse repository at this point
Copy the full SHA e87d4e8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.