Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document destructuring configuration #396

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

satrapu
Copy link
Contributor

@satrapu satrapu commented Aug 28, 2023

No description provided.

Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for putting this together!

Tried to do a thorough nitpicky pass over it, wrote up a few ideas/comments 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@satrapu
Copy link
Contributor Author

satrapu commented Aug 29, 2023

Hey @nblumhardt,

Thanks for your feedback - all suggestions have been addressed.

README.md Show resolved Hide resolved
@nblumhardt nblumhardt merged commit 0b7db17 into serilog:dev Aug 30, 2023
1 check passed
@satrapu satrapu deleted the document-destructuring-configuration branch August 30, 2023 06:45
@nblumhardt nblumhardt mentioned this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants