Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA1416: Validate platform compatibility #43

Closed
davidjamartin opened this issue Nov 18, 2021 · 2 comments
Closed

CA1416: Validate platform compatibility #43

davidjamartin opened this issue Nov 18, 2021 · 2 comments

Comments

@davidjamartin
Copy link

As the event log is only supported on the Windows Platform, should the classes be decorated with the SupportedOSPlatform attribute?

[SupportedOSPlatform("windows")]

See here for more information:
https://docs.microsoft.com/en-gb/dotnet/fundamentals/code-analysis/quality-rules/ca1416

@gfoidl
Copy link

gfoidl commented May 30, 2022

This would make sense, especially as there is

if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
throw new PlatformNotSupportedException(RuntimeInformation.OSDescription);
}

@Numpsy
Copy link
Member

Numpsy commented Jun 30, 2024

Is this fixed now?
ref #52 / #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants