Merge pull request #227 from nblumhardt/unpin-assembly-version

Unpin the assembly version
serilog · Jun 22, 2021 · be730d4 · be730d4
2 parents d599eb6 + 6f43751
commit be730d4
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/src/Serilog.Sinks.File/Properties/AssemblyInfo.cs b/src/Serilog.Sinks.File/Properties/AssemblyInfo.cs
@@ -2,8 +2,6 @@
 using System.Reflection;
 using System.Runtime.CompilerServices;
 
-[assembly: AssemblyVersion("2.0.0.0")]
-
 [assembly: CLSCompliant(true)]
 
 [assembly: InternalsVisibleTo("Serilog.Sinks.File.Tests, PublicKey=" +

diff --git a/src/Serilog.Sinks.File/Serilog.Sinks.File.csproj b/src/Serilog.Sinks.File/Serilog.Sinks.File.csproj
@@ -16,7 +16,6 @@
     <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
     <RepositoryUrl>https://github.com/serilog/serilog-sinks-file</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
-    <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
     <RootNamespace>Serilog</RootNamespace>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <DisableImplicitFrameworkReferences Condition=" '$(TargetFramework)' == 'netstandard1.3' ">true</DisableImplicitFrameworkReferences>

diff --git a/test/Serilog.Sinks.File.Tests/RollingFileSinkTests.cs b/test/Serilog.Sinks.File.Tests/RollingFileSinkTests.cs
@@ -3,7 +3,6 @@
 using System.IO;
 using System.IO.Compression;
 using System.Linq;
-using System.Reflection;
 using Xunit;
 using Serilog.Events;
 using Serilog.Sinks.File.Tests.Support;
@@ -128,7 +127,7 @@ public void WhenRetentionCountAndTimeIsSetOldFilesAreDeletedByCount()
                     Assert.True(System.IO.File.Exists(files[2]));
                 });
         }
-      
+
         [Fact]
         public void WhenRetentionCountAndArchivingHookIsSetOldFilesAreCopiedAndOriginalDeleted()
         {
@@ -261,13 +260,6 @@ public void IfTheLogFolderDoesNotExistItWillBeCreated()
             }
         }
 
-        [Fact]
-        public void AssemblyVersionIsFixedAt200()
-        {
-            var assembly = typeof(FileLoggerConfigurationExtensions).GetTypeInfo().Assembly;
-            Assert.Equal("2.0.0.0", assembly.GetName().Version.ToString(4));
-        }
-
         static void TestRollingEventSequence(params LogEvent[] events)
         {
             TestRollingEventSequence(