Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Core support #47

Closed
dotnetjalps opened this Issue Sep 2, 2016 · 16 comments

Comments

Projects
None yet
9 participants
@dotnetjalps
Copy link

dotnetjalps commented Sep 2, 2016

Hello Team,

I can see that now serilog supports .NET Core platform. Is this package serilog-sinks-mssqlserver pacakge also support .NET Core?

@kizilsum

This comment has been minimized.

Copy link

kizilsum commented Sep 4, 2016

I am also facing with this issue. Serilog.MSSqlServer 4.1.0 cannot be restored for my .NetCore App.

@nblumhardt nblumhardt changed the title Does serilog-sinks-mssqlserver support .NET Core plateform .NET Core support Sep 4, 2016

@nblumhardt

This comment has been minimized.

Copy link
Member

nblumhardt commented Sep 4, 2016

Hi all- #34 is one work-in-progress item on this, but is moving slowly. Help/input on the PR welcome.

@nblumhardt

This comment has been minimized.

Copy link
Member

nblumhardt commented Oct 24, 2016

The APIs used by this package will be available in the next .NET Core/.NET Standard releases (dotnet/corefx#12426) - we're going to hold fire here until that's available.

@nblumhardt nblumhardt closed this Oct 24, 2016

@nblumhardt nblumhardt reopened this Oct 24, 2016

@stsomewheredesign

This comment has been minimized.

Copy link

stsomewheredesign commented Feb 21, 2017

Has there been any progress on this? I'm trying to use the SqlServer 4.20 sink with a .NET Core 1.0 application and receive the following error when trying to install via the Package Manager:

Package Serilog.Sinks.MSSqlServer 4.2.0 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package Serilog.Sinks.MSSqlServer 4.2.0 supports: net45 (.NETFramework,Version=v4.5) One or more packages are incompatible with .NETCoreApp,Version=v1.0.

@nblumhardt

This comment has been minimized.

Copy link
Member

nblumhardt commented Feb 21, 2017

@stsomewheredesign we're still holding off for .NET Core 2.0 before moving this sink.

In the meantime however, there's

@srollinet

This comment has been minimized.

Copy link

srollinet commented Sep 5, 2017

Hi! Any news about this issue? As netstandard2 is now out.

@nblumhardt

This comment has been minimized.

Copy link
Member

nblumhardt commented Sep 5, 2017

@srollinet great that this one can finally move forward!

No one is working on a PR at the moment, as far as I'm aware - if anyone on the thread can help out, please leave a comment, happy to help with the process.

@buzallen

This comment has been minimized.

Copy link

buzallen commented Sep 21, 2017

I played around with this today. First, I targeted .net 4.6.1 which I believe is netstandard 2.0 compliant. I got that compiling and passing tests. Pretty much just adding packages and changing references.

Does Serilog itself need to be netstandard 2.0 prior to targeting it with the project? Next thing I'm going to attempt is to add 2.0 as a target framework.

@nblumhardt

This comment has been minimized.

Copy link
Member

nblumhardt commented Sep 21, 2017

Hi Brian, thanks for taking a look! Much appreciated.

No, Serilog's already compatible with .NET Standard 2.0 - only this package should need to change 👍

@buzallen

This comment has been minimized.

Copy link

buzallen commented Sep 21, 2017

It should have occurred to me that it is .NET standard compatible as I am using serilog in a .net core 2 asp mvc app :) I was thrown off by an error. I'll try building it targeting 2.0 tomorrow and using it in an app.

I briefly added .net standard 2.0 as a target this evening an saw a bunch of warnings and errors with the test project but the main project appeared to build OK. More later...

@buzallen

This comment has been minimized.

Copy link

buzallen commented Sep 21, 2017

I can confirm that it just takes some package and reference modifications to get it working. I have the sink working with a demo asp mvc core 2.0 application. I currently only have the project targeting Net standard 2.0 so I need to go back and set it up for multi targeting and there are some issues with the test project under 2.0 but I don't see any major work needed.

@nblumhardt

This comment has been minimized.

Copy link
Member

nblumhardt commented Sep 22, 2017

🎉 great news! Thanks for the update, @buzallen.

@andrebires

This comment has been minimized.

Copy link

andrebires commented Oct 13, 2017

#94

@Kaidanov

This comment has been minimized.

Copy link

Kaidanov commented Jun 28, 2018

Package Serilog.Sinks.MSSqlServer 5.1.2 is not compatible with netcoreapp2.0
Any solutions?

@MV10

This comment has been minimized.

Copy link
Contributor

MV10 commented Aug 23, 2018

@Kaidanov one of the 5.1.3-dev packages is required. If you use appsettings.json for configuration, you also need the 3.0.0-dev package.

@nblumhardt is there any reason for this thread to remain open? Also, I noticed NuGet still lists the Serilog.Sinks.MSSqlServerCore package which still points to this repo instead of aaxelm's ... seems like the core-specific one should be deprecated or even removed at this point, this package works fine with Core projects today.

@nblumhardt

This comment has been minimized.

Copy link
Member

nblumhardt commented Aug 23, 2018

Thanks for the nudge @MV10 👍

I think the Serilog.Sinks.MSSqlServerCore could be deprecated, but we don't manage it, so someone would need to reach out to the maintianer.

@nblumhardt nblumhardt closed this Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.