Update Serilog.Sinks.PeriodicBatching to take advantage of eager sends
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
reviewed
Jan 3, 2024
src/Serilog.Sinks.OpenTelemetry/Sinks/OpenTelemetry/Exporters/HttpExporter.cs
Show resolved
Hide resolved
bartelink
reviewed
Jan 3, 2024
src/Serilog.Sinks.OpenTelemetry/Sinks/OpenTelemetry/Exporters/HttpExporter.cs
Show resolved
Hide resolved
bartelink
reviewed
Jan 3, 2024
src/Serilog.Sinks.OpenTelemetry/Serilog.Sinks.OpenTelemetry.csproj
Outdated
Show resolved
Hide resolved
bartelink
reviewed
Jan 3, 2024
src/Serilog.Sinks.OpenTelemetry/Serilog.Sinks.OpenTelemetry.csproj
Outdated
Show resolved
Hide resolved
…proj Co-authored-by: Ruben Bartelink <ruben@bartelink.com>
…proj Co-authored-by: Ruben Bartelink <ruben@bartelink.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Serilog.Sinks.PeriodicBatching is implemented over System.Threading.Channels and uses a new internal algorithm that sends batches as soon as they're full, rather than waiting for the buffering period to elapse.
Seems enough of an improvement that we'd want to adopt it here, so pulling in the prerelease package to contribute some test cycles :-)