Add headers and resourceAttributes to simple configuration methods #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The need to authenticate requests, and to configure resource attributes, makes JSON configuration of this sink impractical today in many scenarios.
Serilog.Settings.Configuration is gaining support for dictionary values in configuration; adding those parameters to the simplified configuration methods here will help drive, validate, and support that change.
This is a binary breaking change, but will be source compatible. This should be fine in a 2.0.0 :-)