Don't stack overflow when disposing ReusableStringWriter (#1977)

* Don't stack overflow when disposing ReusableStringWriter * Don't attempt to reuse a pooled writer if it's being finalized
serilog · Nov 10, 2023 · 16739f0 · 16739f0
1 parent ca4efda
commit 16739f0
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/Serilog/Rendering/ReusableStringWriter.cs b/src/Serilog/Rendering/ReusableStringWriter.cs
@@ -39,10 +39,16 @@ public static StringWriter GetOrCreate(IFormatProvider? formatProvider = null)
     /// </summary>
     protected override void Dispose(bool disposing)
     {
+        if (!disposing)
+        {
+            base.Dispose(disposing);
+            return;
+        }
+
         var sb = GetStringBuilder();
         if (sb.Capacity > StringBuilderCapacityThreshold)
         {
-            base.Dispose();
+            base.Dispose(disposing);
             return;
         }
         // We don't call base.Dispose because all it does is mark the writer as closed so it can't be