New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wrong tag #1699
Remove wrong tag #1699
Conversation
@@ -32,7 +32,6 @@ public class PropertyEnricher : ILogEventEnricher | |||
/// </summary> | |||
/// <param name="name">The name of the property.</param> | |||
/// <param name="value">The value of the property.</param> | |||
/// <returns>A handle to later remove the property from the context.</returns> | |||
/// <param name="destructureObjects">If true, and the value is a non-primitive, non-array type, | |||
/// then the value will be converted to a structure; otherwise, unknown types will | |||
/// be converted to scalars, which are generally stored as strings.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is L39 superfluous too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EnsureValidName throws this exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies; L38 in your version, i.e. wondering (without having it in an IDE) whether /// <returns></returns>
is necessary before the exception list (there isn't one before the method after, but perhaps it is necessary for a ctor)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooops, fixed
Thanks @sungam3r, looks good! |
* Remove wrong tag * fix
No description provided.