Introduce ScalarValue.Null #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
commented
Dec 2, 2022
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
nblumhardt
approved these changes
Dec 3, 2022
There was a problem hiding this comment.
Nice! Seems like a low-risk win 👍
My only thought was whether there'd be any advantage to keeping the static property entirely internal, but seems reasonable to expose it and encourage similar usage in other places.
true and false might also be good candidates for this treatment.
|
I can add cached common values in another pr. |
Co-authored-by: C. Augusto Proiete <augusto@proiete.com>
sungam3r
commented
Dec 13, 2022
| @@ -409,6 +410,7 @@ namespace Serilog.Events | |||
| { | |||
| public SequenceValue(System.Collections.Generic.IEnumerable<Serilog.Events.LogEventPropertyValue> elements) { } | |||
| public System.Collections.Generic.IReadOnlyList<Serilog.Events.LogEventPropertyValue> Elements { get; } | |||
| public static Serilog.Events.SequenceValue Empty { get; } | |||
There was a problem hiding this comment.
@nblumhardt I pulled changes from dev to fix approval file after merging #1785.
SimonCropp
approved these changes
Dec 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves some allocations.