Reinstate LoggerSinkConfiguration.Sink(ILogEventSink, LogEventLevel)

[nblumhardt]

I just switched Seq over to Serilog 3 dev and the latest versions of our dependencies, but because of some transitive dependencies in the build I hit:

System.MissingMethodException: Method not found: 'Serilog.LoggerConfiguration Serilog.Configuration.LoggerSinkConfiguration.Sink(Serilog.Core.ILogEventSink, Serilog.Events.LogEventLevel)'.
   at Serilog.SeqLoggerConfigurationExtensions.<>c__DisplayClass3_0.<Seq>b__0(LoggerSinkConfiguration wt)
   at Serilog.Configuration.LoggerSinkConfiguration.Wrap(LoggerSinkConfiguration loggerSinkConfiguration, Func`2 wrapSink, Action`1 configureWrappedSink, LogEventLevel restrictedToMinimumLevel, LoggingLevelSwitch levelSwitch)
   at Serilog.Configuration.LoggerSinkConfiguration.Conditional(Func`2 condition, Action`1 configureSink)
   at Serilog.SeqLoggerConfigurationExtensions.Seq(LoggerSinkConfiguration loggerSinkConfiguration, String serverUrl, LogEventLevel restrictedToMinimumLevel, Int32 batchPostingLimit, Nullable`1 period, String apiKey, String bufferBaseFilename, Nullable`1 bufferSizeLimitBytes, Nullable`1 eventBodyLimitBytes, LoggingLevelSwitch controlLevelSwitch, HttpMessageHandler messageHandler, Nullable`1 retainedInvalidPayloadsLimitBytes, Int32 queueSizeLimit)
   at Seq.Build.Program.Main(String[] rawArgs) in C:\projects\seq\ci\Seq.Build\Program.cs:line 33

We speculatively removed it in #1800.

I think this is going to be a common experience; for the cost of one overload that wasn't already [Obsolete] I think walking this change back is a good trade-off.

I've left the other removal from #1800 alone as we don't have any evidence of breakage at this point.

[augustoproiete]

LGTM

[sungam3r]

How does hang look like? I do not use NoDiff in other repos and did not see issues.

[nblumhardt]

That's a good question, I may have jumped the gun here, based on experience with other tools that launch windowed executables for this.

[sungam3r]

Why not obsolete?

[nblumhardt]

It's impossible to stop the compiler selecting it when doing overload resolution, and thus marking it obsolete results in a spurious warning.