Add LevelAlias.Off; fixes #1684
#1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The question of what to do about turning logging completely off via a
MinimumLevel.Override, and how to map MEL'sLogLevel.Offin configuration, has been open for a long time.The arguments against putting this on
LogEventLevelcenter aroundOffnot being a valid value to find attached to aLogEvent.This PR is an attempt to side-step the issue via
LevelAlias. AddingOffhere doesn't sanction constructing an event with theOfflevel, but gives us and everyone else an indication that theOffvalue will be respected in minimum level overrides and JSON configuration (some downstream work required in Serilog.Settings.Configuration for this).What do you think?