By reference string comparison in template cache #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How would the numbers come out if we ditched the fall-through to the by-value cache? There's a good case to be made for reducing memory use by dropping the second dictionary; anyone who is formatting message "templates" dynamically is probably not actually using message templates and is likely to be generating unique strings anyway, so the situations that will actually benefit from the second layer of caching are pretty limited. |
epeshk
force-pushed
the
by-ref-comparer
branch
from
8c5d66e
to
fd4a407
Compare
|
Yes, I agree that it's better to remove by-value cache completely |
|
LGTM 👍 Interested whether anyone else can spot gotchas I might have missed so will leave this a few more days. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1946