Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReusableStringWriter: Dispose instance with too big buffer #1964

Merged
merged 1 commit into from Oct 9, 2023

Conversation

Jakimar
Copy link
Contributor

@Jakimar Jakimar commented Oct 9, 2023

Fixes #1963
StringBuilderCapacityThreshold is subject to discuss

@nblumhardt
Copy link
Member

Makes sense, and the default seems reasonable - thanks 👍

@nblumhardt nblumhardt merged commit 8d0e2ed into serilog:dev Oct 9, 2023
1 check passed
@nblumhardt nblumhardt mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReusableStringWriter: Potentional high memory usage\leak
3 participants