fix: version should retrieve from tags output #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: msclock <msclock@qq.com>
msclock
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #250 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 24 24
=========================================
Hits 24 24 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 1.4.42 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had retrieved versions from
git describeoutout cmake variable brefore, but it only is valid when using annotated tags. Now, switch to useCMAKE_PROJECT_GIT_COMMIT_TAGandCMAKE_PROJECT_GIT_COMMIT_TAG_REVISIONto splice as the project version.