Skip to content
This repository has been archived by the owner on Feb 3, 2024. It is now read-only.

Format fixes followup #43

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Format fixes followup #43

merged 3 commits into from
Jun 20, 2023

Conversation

rodabt
Copy link
Contributor

@rodabt rodabt commented Jun 19, 2023

No description provided.

@rodabt
Copy link
Contributor Author

rodabt commented Jun 20, 2023

Hi @serkonda7! I made a few changes, and all formats and tests should pass now.

Copy link
Owner

@serkonda7 serkonda7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Is it really necessary to move the constants to termtable.v tho?
To me this seems like V has something improperly implemented there.

@rodabt
Copy link
Contributor Author

rodabt commented Jun 20, 2023

Thanks!

Is it really necessary to move the constants to termtable.v tho? To me this seems like V has something improperly implemented there.

Tried other combinations, but it seems putting consts on the main file was the only one to pass both formatting and tests.

According to the manual: Outside from module main all constants need to be prefixed with the module name.

Tried that too, like termtable.[const_var], but didn't work.

@serkonda7 serkonda7 merged commit 89f2ca4 into serkonda7:master Jun 20, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants