Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

How to add new plants/relationships? #23

Open
coatesap opened this issue Mar 29, 2020 · 4 comments
Open

How to add new plants/relationships? #23

coatesap opened this issue Mar 29, 2020 · 4 comments

Comments

@coatesap
Copy link

Hi, this is a great tool, and I'd love to contribute some additional plants/relationships.

Would it be possible to add a "Contributing" section to the readme that explains the project setup and the basic steps to add new plant and relationship data (with any gotchas/things to consider)?

If not, that's fine - it looks reasonably straight-forward. The only immediate question that jumped out at me was that data/relations-data.js looked like it had been minified, but I couldn't see a non-minified version to make edits to?

@elbotho
Copy link
Member

elbotho commented Mar 29, 2020

Hey there, thanks for reaching out!
There was an "backend" at the beginning which we used to get started with the bulk of the data.

Since then (hacky backend aside) I put quite some thought into a proper way to manage the data for this project.
But to be honest there was not a lot of interest in collaboration so far so I never finished anything.

So my questions:

  • Did you plan on adding a lot of relations/plants? What are your sources?
  • Would you be interested working on setting up a simple, stable and usable process?

@coatesap
Copy link
Author

No, I wasn't planning on adding a lot of new plants - just some of the more common (UK) garden vegetables like Courgette (Zucchini).

I'm not aware of 100% authoritative sources for companion planting, but would attempt to find 2-3 relatively reputable sources for any new relationships. Sites like https://www.farmersalmanac.com/companion-planting-guide-31301 that provide an explanation for any recommendations, for instance.

I don't have a lot of available time, but would be willing to put in a few hours here and there.

@elbotho
Copy link
Member

elbotho commented Mar 30, 2020

Quickfix:
Maybe we should just rename this one 😉
https://plantbuddies.serlo.org/🌿/marrow

Will think about a way again, but might take some time as this is also very much a side project atm.

@coatesap
Copy link
Author

Ha - I didn't even think of searching for "Marrow". I guess they're not grown as Marrows that often in the UK (or the US, AFAIK) so renaming to Courgette or Zucchini would definitely be the quick fix!

A 'nice to have' would be if the autocomplete could also work on the alternative names.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants