Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue of plugin config reload dynamically failure #1521

Merged
merged 1 commit into from
May 28, 2024

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented May 23, 2024

What type of PR is this?

Bug

What this PR does / why we need it?

Add a custom yaml constructor for snakeyaml to make the same plugin config string can be loaded by new pluginclassloader rather than old pluginclassloader when install a plugin at the second time

Which issue(s) this PR fixes?

Fixes #1520

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Flag Coverage Δ Complexity Δ
unittests 43.00% <0.00%> (-0.04%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ Complexity Δ
...rmant/core/config/strategy/LoadConfigStrategy.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rmant/implement/config/LoadPropertiesStrategy.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ain/java/io/sermant/core/config/ConfigManager.java 6.89% <0.00%> (ø) 0.00 <0.00> (ø)
...ermant/core/plugin/config/PluginConfigManager.java 14.70% <0.00%> (-0.45%) 0.00 <0.00> (ø)
.../io/sermant/implement/config/LoadYamlStrategy.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rmant/implement/config/SermantYamlConstructor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

... and 2 files with indirect coverage changes

Signed-off-by: lilai <lilai23@foxmail.com>
@Sherlockhan Sherlockhan merged commit 3555fdb into sermant-io:develop May 28, 2024
280 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fail to load plugin config dynamically at the second time
4 participants