Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Module Reloading Enhancements #77

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Module Reloading Enhancements #77

merged 1 commit into from
Apr 26, 2021

Conversation

sernst
Copy link
Owner

@sernst sernst commented Apr 26, 2021

This PR improves the handling of module reloading to
prevent changed dependencies between modified modules
from preventing the reload process from completing
successfully. The failure mode comes about when changes
in one module are imported into another module and by
the previous sorting method, the importing module is
reloaded first.

This PR improves the handling of module reloading to
prevent changed dependencies between modified modules
from preventing the reload process from completing
successfully. The failure mode comes about when changes
in one module are imported into another module and by
the previous sorting method, the importing module is
reloaded first.
@sernst sernst force-pushed the module-reload-enhancements branch from 3cd5526 to 5096388 Compare April 26, 2021 14:21
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #77 (5096388) into master (66ef091) will increase coverage by 0.21%.
The diff coverage is 98.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   98.77%   98.99%   +0.21%     
==========================================
  Files         295      296       +1     
  Lines       12355    12366      +11     
==========================================
+ Hits        12204    12242      +38     
+ Misses        151      124      -27     
Impacted Files Coverage Δ
cauldron/cli/server/run.py 98.63% <ø> (+14.36%) ⬆️
cauldron/ui/__init__.py 100.00% <ø> (+16.66%) ⬆️
cauldron/runner/__init__.py 94.06% <96.42%> (+0.67%) ⬆️
cauldron/test/runner/test_reload_libraries.py 100.00% <100.00%> (ø)
cauldron/session/projects/project.py 96.80% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ef091...5096388. Read the comment docs.

@sernst sernst merged commit af6ad42 into master Apr 26, 2021
@sernst sernst deleted the module-reload-enhancements branch April 26, 2021 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant