Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#126] Add the ceiling counterparts to the floor functions #131

Merged

Conversation

breakerzirconia
Copy link
Contributor

@breakerzirconia breakerzirconia commented Jun 20, 2022

Problem: We have floorRat and floorUnit for flooring a time unit, but
don't have the ceiling counterparts.

Solution: Define the ceiling functions.

Fixes: #126

@dcastro
Copy link
Member

dcastro commented Jun 22, 2022

Please:

  • update the changelog
  • Add "Fixes: #issuenumber" to the PR's description - this tells github to automatically close that issue when this PR is merged

Problem: We have floorRat and floorUnit for flooring a time unit, but
don't have the ceiling counterparts.

Solution: Define the ceiling functions.
@breakerzirconia breakerzirconia force-pushed the breakerzirconia/#126-add-ceiling-counterparts branch from 3aad9a0 to 34e9442 Compare July 22, 2022 12:44
@breakerzirconia breakerzirconia merged commit 08e4f6a into master Jul 23, 2022
@breakerzirconia breakerzirconia deleted the breakerzirconia/#126-add-ceiling-counterparts branch July 23, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ceiling functions
2 participants