[#63] Add SeriesP class #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshersh
suggested changes
Feb 11, 2018
| instance (KnownRatName unit) => SeriesP '[unit] where | ||
| seriesP :: forall (someUnit :: Rat) . KnownRatName someUnit | ||
| => String -> Maybe (Time someUnit) | ||
| seriesP "" = Just $ Time 0 |
There was a problem hiding this comment.
I think this case (parsing empty string) should be in documentation. It's a hard problem, how we want to handle empty string. But this is not important at the moment. What's important is not to have undocumented behavior.
| >>> seriesP @'[Hour, Second, Millisecond] @Minute "90s" | ||
| Just (1+1/2m) | ||
|
|
||
| >>> seriesP @'[Hour, Second] @Second "11ns" |
There was a problem hiding this comment.
Could you also add examples with something like seriesP @'[Hour, Minute] where you have 1+1/2h and 1+1/2m and 1h1+1/2m?
src/Time/Series.hs
Outdated
| maybeT = readMaybeTime @unit $ num ++ u | ||
| in case maybeT of | ||
| Nothing -> seriesP @(nextUnit ': units) str | ||
| Just _ -> liftA2 (+) maybeT (seriesP @(nextUnit ': units) nextStr) |
There was a problem hiding this comment.
Personally, I don't like ignoring result of Just here. Here you perform manual unwrapping of maybeT and then you pass maybeT to liftA2 function which will do this unwrapping again. It looks better to me to use fmap here, like
Just t -> (t+) <$> seriesP ...
chshersh
approved these changes
Feb 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #63