Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lift hClose #186

Closed
kirelagin opened this issue Aug 7, 2018 · 2 comments
Closed

Lift hClose #186

kirelagin opened this issue Aug 7, 2018 · 2 comments
Labels
type:feature Something new is added.
Milestone
v1.5.0: generous ...

Comments

@kirelagin
Copy link

Universum.Lifted.File lift functions for opening, reading and writing files, but nothing to close them.
@gromakovsky gromakovsky added the type:feature Something new is added. label Aug 12, 2018
@gromakovsky
Copy link
Member

I think there are two options: export hClose (lifted version) or remove export of openFile and export withFile instead (probably with MonadMask constraint, MonadIO is not enough) because one should use withFile whenever possible.
Or we can export all three :)

JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 5, 2018
@JustusAdam
[serokell#186] Implemented hClose and withFile
93a1877
@JustusAdam JustusAdam mentioned this issue Oct 5, 2018
Merged
JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 11, 2018
@JustusAdam
[serokell#186] Implemented hClose and withFile
0854709
JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 11, 2018
@JustusAdam
[serokell#186] Specialized file manipulations to IO
9e66cb3
JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 11, 2018
@JustusAdam
[serokell#186] Expanded documentation of Handle manipulation functions
7c3d1c9 
Made it so it heavily nudges the user to use withFile and the likes over
openFile and hClose
JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 11, 2018
@JustusAdam
[serokell#186] Recorded withFile and hClose changes
db058db
JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 15, 2018
@JustusAdam
[serokell#186] Implemented hClose and withFile
4d25bc4
JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 15, 2018
@JustusAdam
[serokell#186] Specialized file manipulations to IO
b311ea7
JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 15, 2018
@JustusAdam
[serokell#186] Expanded documentation of Handle manipulation functions
0baeba7 
Made it so it heavily nudges the user to use withFile and the likes over
openFile and hClose
JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 15, 2018
@JustusAdam
[serokell#186] Recorded withFile and hClose changes
fd09b12
gromakovsky added a commit that referenced this issue Oct 16, 2018
@gromakovsky
Merge pull request #200 from JustusAdam/with-file
ad1bf2c 
[#186] Implemented hClose and withFile
@gromakovsky
Copy link
Member

Done in #200.

JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 28, 2018
@JustusAdam
[serokell#186] Implemented hClose and withFile
bc30001
JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 28, 2018
@JustusAdam
[serokell#186] Specialized file manipulations to IO
ef660a4
JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 28, 2018
@JustusAdam
[serokell#186] Expanded documentation of Handle manipulation functions
de6e795 
Made it so it heavily nudges the user to use withFile and the likes over
openFile and hClose
JustusAdam added a commit to JustusAdam/universum that referenced this issue Oct 28, 2018
@JustusAdam
[serokell#186] Recorded withFile and hClose changes
dd53f41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature Something new is added.
Projects
None yet
Milestone
v1.5.0: generous contributions
Development

No branches or pull requests
2 participants
@kirelagin @gromakovsky