[#281] Allow text-2.0 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martoon-00
force-pushed
the
martoon/bump-text-2.0
branch
from
9f707cc
to
bc0128d
Compare
|
Is there any progress here? |
Problem: the current `bgroupTextConversion` benchmarks turn out to be unrepresentative now, they show the same (small) time disregard whether do we have rewrite rules or not. Probably this happened because in `text` they added some smart rewrite rules on composition of `pack` with some other functions. E.g. `Text.length . pack` is now rewritten to `List.length`. Solution: replace the old benchmarks that used `length` with a trivial benchmark that simply does `toText . toString`. Notes: Previously I preferred having relatively complex scenarios to demonstrate that not only trivial `toText . toString` will get short-circuited. However, it's getting hard to setup a non-trivial case where our rewrite rules would matter, and this is natural as `text` package tries to be optimal in as many scenarios as possible. So soon it may happen that any simple case of code will be optimal even without our own rewrite rule.
Problem: new major version of `text` has been released, and we do not yet allow it. Solution: increase the upper bound version of `text` to the most recent `2.0.1` one. I checked that rewrite rule is still working, actual, and affects the benchmark.
Problem: changelog wasn't updated for 1.8.1 in #271 Also we would like to make a new release to support text-2.something Solution: 1. Add 1.8.1 changelog entry with the old change. 2. Add 1.8.1.1 with the new change. Note that in Haskell code we only updated the benchmarks, changed one comment and dependency bounds. 3. Update the package version.
gromakovsky
force-pushed
the
martoon/bump-text-2.0
branch
from
bc0128d
to
3658c81
Compare
dcastro
reviewed
Feb 20, 2023
dcastro
approved these changes
Feb 20, 2023
|
@Swordlash thank you for the reminder, apparently I missed this PR or forgot about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase the version upper bound on
textpackage.The related logic (
pack,unpack) seems to be untouched, and the rewrite rule speeds up a call oftoString . toText.Related issues(s)
Fixed #281
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
are inextricably linked. Otherwise I should open multiple PR's.
I checked whether these changes impact the
.hlint.yamlrulesand updated them if needed.
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
and
Stylistic guide (mandatory)
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit descriptionIf necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.
✓ Release Checklist
universum.cabal.under the "Unreleased" section to a new section for this release version.
I added
@sincehaddock annotations.with a summary of all user-facing changes.
vX.Y.Z