[Chore] Use LTS-21 #290
Open
[Chore] Use LTS-21 #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
gromakovsky
force-pushed
the
gromak/lts-21
branch
3 times, most recently
from
693d6ac
to
27cc45d
Compare
gromakovsky
force-pushed
the
gromak/lts-21
branch
from
27cc45d
to
06cd8ab
Compare
Problem: we take nyan-interpolation from GitHub, which is harder to manage than if we take it from Hackage. Fortunately, the latest version is now available and suits us. Solution: specify Hackage version of nyan-interpoation[-core] in extra-deps.
gromakovsky
force-pushed
the
gromak/lts-21
branch
from
06cd8ab
to
f57d93a
Compare
|
CI is failing due to warnings / compilation errors also related to LTS-21. Other than that, LGTM. |
|
@Martoon-00 if you volunteer to fix them by any chance, feel free to go ahead 😉 |
|
Okay, I fixed the errors that I saw (note there are fixup commits, you may want to squash them after reviewing them). However now some really scary errors bumped up, and I have to switch to other activities, so giving up on this right now. |
Problem: we use lts-19.13 which is getting somewhat old. It's a good practice to update versions from time to time. Solution: use lts-21.25.
1. The project no longer uses `niv`, so the comment about it is irrelevant. Dependencies are normally updated by the update-daemon nowadays. 2. cmark-gfm is available in lts-21.13.
Problem: this is a new warning which wants us to provide an explicit kind signature for each type we define. It sounds too verbose to do. Solution: disable this warning.
Problem: retryAfterInfo doesn't compile because the type of readMaybe got more polymorphic in Universum. Solution: specify explicitly that the argument is Text. N.B. In the previous version it was String (due to the old type of readMaybe), but Text is generally preferable, so we're changing it.
Problem: some lens-related things that we use got deprecated in Universum. Solution: do not use them, import them from Control.Lens instead.
Problem: CI job for Windows compiles against specific GHC version. Solution: update it to match LTS version.
Problem: somehow, after the previous commits one test broke, now xrefcheck outputs location where previously it didn't. Solution: it seems for good, so update the expected output in that test.
gromakovsky
force-pushed
the
gromak/lts-21
branch
from
19b21f2
to
83ea8a3
Compare
Reviewed, squashed. Also updated the resolved to a bit newer one, so that a newer minor GHC version is used. Let's see if it helps with any of scary errors. |
Problem: Cross-compilation to windows is broken. Solution: 1) Build 'bitvec' without 'simd' flag since it causes the build to fail. 2) Remove old workaround for 'iserv-proxy-interprete' because the aforementioned issue was fixed in newer GHC versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updated the Stackage resolver to the latest one and does some related cleaning.
Related issue(s)
Resolves #285
✅ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)
✓ Release Checklist
package.yaml.under the "Unreleased" section to a new section for this release version.
vX.Y.Z.xrefcheck-action.