Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set bundler environmental variables when they are provided #35

Merged
merged 2 commits into from
May 26, 2023

Conversation

hsbt
Copy link
Contributor

@hsbt hsbt commented May 25, 2023

Hello, I'm maintainer of RubyGems and Bundler.

Bundler repo vendored turbo_tests for our test suites like https://github.com/rubygems/rubygems/tree/master/bundler/tool/turbo_tests. I hope to use release version of turbo_tests, not vendoring.

I removed bundle exec from commands builder of turbo_tests if they didn't use turbo_tests under the bundler because Bundler need to use turbo_tests without bundler environment.

How about this?

Thank you for develop this ❤️

@ilyazub
Copy link
Collaborator

ilyazub commented May 26, 2023

Hello, @hsbt! It's a great honor for me!

I'll test your PR manually and share my feedback.

Thanks to Discourse and RubyGems teams for the initial development of turbo_tests ♥️

Copy link
Collaborator

@ilyazub ilyazub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Works as usual with and without bundle exec.

I'll merge and release this change in 2.1.0 version.

Edit:

Released:

@ilyazub ilyazub merged commit 2f0f152 into serpapi:master May 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants