Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support #50
Windows support #50
Changes from 3 commits
d0246f2
3b70426
df946e7
b4ad8f4
8af698e
1fa426c
1f714bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the best way to detect Bundler binstubs and/or if
bundle exec
is used?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point too! Using
bin/rspec
directly is quite specific to our environment. I guess we could detect whether there's abin/rspec
file relative to the cwd, and otherwise usebundle exec rspec
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will Windows correctly handle this if we append
$PWD/bin
to ENV["PATH"] instead of detectingbin/rspec
? (I'm new to Bundler internals. Below is a hacky pseudo-code.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would handle it fine, but I'm not sure it's a good idea since it would have global side effects. Users have other scripts in
bin/
and maybe won't expect turbo_tests to automatically set things up so that those other scripts start getting selected when their tests run processes? Not sure.Maybe we can start leaving things as they are regarding building the command name for now. I could configure
$LOAD_PATH
on our side before launching turbo_tests so that our binstub gets properly loaded.