Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Show all packages that are to be installed #35

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

der-eismann
Copy link
Member

@der-eismann der-eismann commented Apr 11, 2023

Since this is a div operation, e.g. 57 / 9 = 6, causing it to display only 9 * 6 = 54 packages in the end. Easy fix, just round the result up.

Fixes #19 I think.

Before:

The following packages will be installed
...
acl - 2.3.1-2             fakeroot - 1.31-2         libffi - 3.4.4-3          nghttp2 - 1.52.0-3        
attr - 2.5.1-2            findutils - 4.9.0-2       libxcrypt - 4.4.33-3      nss - 3.88.1-6            
attr-devel - 2.5.1-2      gawk - 5.2.1-2            libxml2 - 2.10.3-4        openssl - 3.1.0-5         
autoconf - 2.71-3         gdbm - 1.23-2             linux-headers - 6.2.10-9  pcre2 - 10.42-3           
automake - 1.16.5-3       glibc - 2.37-6            linux-pam - 1.5.2-6       perl - 5.36.0-4           
bash - 5.2.15-5           glibc-devel - 2.37-6      lld - 15.0.7-6            pkgconf - 1.9.4-6         
boulder - 0.1-33          gmp - 6.2.1-2             llvm - 15.0.7-6           readline - 8.2-3          
brotli - 1.0.9-3          grep - 3.10-4             llvm-libs - 15.0.7-6      sed - 4.9-2               
clang - 15.0.7-6          kmod - 30-5               lz4 - 1.9.4-1             slibtool - 0.5.34-4       
clang-libs - 15.0.7-6     libarchive - 3.6.2-2      m4 - 1.4.19-2             systemd - 252.7-9         
coreutils - 9.2-3         libcap - 2.67-3           make - 4.4.1-3            util-linux - 2.38.1-5     
curl - 7.88.1-5           libcap-ng - 0.8.3-2       moss-container - 0.2-5    xxhash - 0.8.1-2          
dash - 0.5.12-2           libcxx - 15.0.7-5         mpfr - 4.2.0-3            xz - 5.4.2-6              
diffutils - 3.9-3         libcxx-devel - 15.0.7-5   ncurses - 6.4-6           zlib - 1.2.13-8

After:

The following 57 package(s) will be installed
...
acl - 2.3.1-2             findutils - 4.9.0-2       libxml2 - 2.10.3-4        pcre2 - 10.42-3           
attr - 2.5.1-2            gawk - 5.2.1-2            linux-headers - 6.2.10-9  perl - 5.36.0-4           
attr-devel - 2.5.1-2      gdbm - 1.23-2             linux-pam - 1.5.2-6       pkgconf - 1.9.4-6         
autoconf - 2.71-3         glibc - 2.37-6            lld - 15.0.7-6            readline - 8.2-3          
automake - 1.16.5-3       glibc-devel - 2.37-6      llvm - 15.0.7-6           sed - 4.9-2               
bash - 5.2.15-5           gmp - 6.2.1-2             llvm-libs - 15.0.7-6      slibtool - 0.5.34-4       
boulder - 0.1-33          grep - 3.10-4             lz4 - 1.9.4-1             systemd - 252.7-9         
brotli - 1.0.9-3          kmod - 30-5               m4 - 1.4.19-2             util-linux - 2.38.1-5     
clang - 15.0.7-6          libarchive - 3.6.2-2      make - 4.4.1-3            xxhash - 0.8.1-2          
clang-libs - 15.0.7-6     libcap - 2.67-3           moss-container - 0.2-5    xz - 5.4.2-6              
coreutils - 9.2-3         libcap-ng - 0.8.3-2       mpfr - 4.2.0-3            zlib - 1.2.13-8           
curl - 7.88.1-5           libcxx - 15.0.7-5         ncurses - 6.4-6           zstd - 1.5.4-3            
dash - 0.5.12-2           libcxx-devel - 15.0.7-5   nghttp2 - 1.52.0-3        
diffutils - 3.9-3         libffi - 3.4.4-3          nss - 3.88.1-6            
fakeroot - 1.31-2         libxcrypt - 4.4.33-3      openssl - 3.1.0-5    

@der-eismann der-eismann changed the title Show all packages, that are to be installed Show all packages that are to be installed Apr 11, 2023
@der-eismann der-eismann force-pushed the show-all-install-packages-correctly branch 3 times, most recently from b3c6df1 to 69e0303 Compare April 12, 2023 13:52
@der-eismann der-eismann force-pushed the show-all-install-packages-correctly branch from 69e0303 to 1120ffb Compare April 12, 2023 14:09
Copy link
Member

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ermo ermo merged commit e572a65 into main Apr 12, 2023
1 check passed
@ermo ermo deleted the show-all-install-packages-correctly branch April 12, 2023 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui.d emitAsColumns does not display all items acted upon
2 participants