Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boulder/moss: Shell completions support #220

Open
ReillyBrogan opened this issue Apr 29, 2024 · 1 comment · May be fixed by #239
Open

boulder/moss: Shell completions support #220

ReillyBrogan opened this issue Apr 29, 2024 · 1 comment · May be fixed by #239
Labels
type: enhancement New feature or request

Comments

@ReillyBrogan
Copy link
Contributor

It looks like we're using clap for the command line parsing, which supports generation of shell completions. We should wire that up.

@ermo ermo added the type: enhancement New feature or request label May 1, 2024
@ermo ermo added this to the oxide-prealpha1 milestone May 1, 2024
ReillyBrogan added a commit that referenced this issue May 9, 2024
This wires up clap_complete so that the `completions` subcommand of boulder and moss will now automatically generate shell completions when provided a shell as the single argument.

Closes #220

Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
@ReillyBrogan ReillyBrogan linked a pull request May 9, 2024 that will close this issue
ReillyBrogan added a commit that referenced this issue May 10, 2024
This wires up clap_complete so that the `completions` subcommand of boulder and moss will now automatically generate shell completions when provided a shell as the single argument.

Closes #220

Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
@livingsilver94
Copy link
Contributor

Random proposal: instead of creating completion files from moss/boulder themselves, which feels like the wrong place to me, we could create them in a build.rs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants