boulder: Fix emul32 incompatibility with dlang boulder #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReillyBrogan
force-pushed
the
emul32-isa
branch
4 times, most recently
from
3e94e41
to
c530b20
Compare
The Rust elf library returns `EM_386` for x86 ELF objects, while we used `x86` as the ISA with the dlang boulder. This results in emul32 packages that are not compatible with packages already in the volatile repo. To "Fix" this make sure we use `x86` for all dependencies, while also adding each dependency twice as both `x86` and `386`. This ensures that newly built packages are compatible with existing ones while also allowing us to switch fully to `386` once every existing emul32 package has been rebuilt. We can also just drop the duplicate `386` provide if we decide to use `x86` instead without any repo issues. Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
ermo
added
status: help wanted
ikeycode
approved these changes
Jul 15, 2024
joebonrichie
added a commit
that referenced
this pull request
Aug 25, 2024
emul32 libs will now depend on 386 variants of the provided emul32 libs instead of x86. Part of #223.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust elf library returns
EM_386for x86 ELF objects, while we usedx86as the ISA with the dlang boulder. This results in emul32 packages that are not compatible with packages already in the volatile repo.To "Fix" this make sure we use
x86for all dependencies, while also adding each dependency twice as bothx86and386. This ensures that newly built packages are compatible with existing ones while also allowing us to switch fully to386once every existing emul32 package has been rebuilt. We can also just drop the duplicate386provide if we decide to usex86instead without any repo issues.