Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phoneNumber for en-US locale #173

Merged
merged 1 commit into from Dec 12, 2022
Merged

Conversation

serpro69
Copy link
Owner

@serpro69 serpro69 commented Dec 12, 2022

I don't like this approach, but I don't know a better way to solve a case where a parameter only exists in a localized dict, i.e.:

phone_number.area_code exists in en-US.yml , but not in phone_number.yml

@serpro69 serpro69 added bug 🐞 Something isn't working core 🧬 Issue related to :core module labels Dec 12, 2022
@serpro69 serpro69 added this to the 1.13.0 milestone Dec 12, 2022
@serpro69 serpro69 linked an issue Dec 12, 2022 that may be closed by this pull request
@serpro69 serpro69 merged commit f73ea55 into master Dec 12, 2022
@serpro69 serpro69 deleted the fix_phone_for_us_locale branch December 12, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working core 🧬 Issue related to :core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function areaCode not found
1 participant