Fix the bug in version comparison and add unit tests. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 224 231 +7
=========================================
+ Hits 224 231 +7
☔ View full report in Codecov by Sentry. |
ffried
approved these changes
Aug 5, 2023
|
@CrazyFanFan Wow, very good catch, thank you! I've fixed the build on Swift 5.6, merged the test method into the main test class (and got rid of the optionals), and simplified the comparison a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the absence of the
==comparison, bothfunc <andfunc >have bugs that can result in situations whereVersion("1.2.3-alpha") > Version("1.2.4")andVersion("1.2.4") > Version("1.2.3-alpha")both returntrue.