Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go1.18 changes subtle things about the type system. Most likely do to the addition of generics. The serum analyzer is a casualty of that. This should fix the immediate problems although it's not entirely clear to me why or if there's another option for handling it.
Testing
go1.18 test ./...
on master will result in errors forCause
functions that should be ignored.Example:
Run the tests with both go1.17 AND go1.18+ to see the difference on both master and this branch.
The master branch still has other errors that may be unimplemented features (use a flag/skip?) or may need to be fixed. This PR does not address that issue.
Here's the expected output on master for go1.17