Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glob support #13

Closed
wants to merge 3 commits into from
Closed

Conversation

thiagodelgado111
Copy link
Contributor

Description

  • This PR adds minimatch support instead of using Regex expressions to map files to ignore
  • It also modifies default config file to use a simplified version of it
  • It also introduce unit tests in place of end-2-end tests available before

Motivation and Context

  • It's easier for users to map files to ignore using "wildcards" than having to put up regular expressions for every case

How Has This Been Tested?

  • It's being unit tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

change configuration default
change configuration loading
ignore source map for ignored files
add sinon.js as a test dependency
update unit tests
@coveralls
Copy link

coveralls commented Aug 15, 2016

Coverage Status

Coverage decreased (-25.4%) to 43.969% when pulling 795f526 on thiagodelgado111:master into 104945d on serut:master.

@codecov-io
Copy link

codecov-io commented Aug 15, 2016

Current coverage is 43.96% (diff: 73.73%)

Merging #13 into master will decrease coverage by 25.44%

@@             master        #13   diff @@
==========================================
  Files            19         19          
  Lines           618        655    +37   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            429        288   -141   
- Misses          189        367   +178   
  Partials          0          0          

Powered by Codecov. Last update 104945d...795f526

@serut
Copy link
Owner

serut commented Aug 15, 2016

Thanks Travis, Codecov, Ci, Coveralls and codacy for this amazing experience.
There are bugs with your release, but with your help we gonna integrate this pull request.

@coveralls
Copy link

Coverage Status

Coverage decreased (-25.4%) to 43.969% when pulling 19d044d on thiagodelgado111:master into 104945d on serut:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-25.4%) to 43.969% when pulling 19d044d on thiagodelgado111:master into 104945d on serut:master.

@serut
Copy link
Owner

serut commented Aug 26, 2016

  • Fix the lint
  • Integrate the branch serut:dev-0.9.4-integrate-glob
  • Rewrite main.js to expose a fake package when coverage isn't active
  • Rewrite corresponding services, reports,... that have protection if coverage isn't active
  • Remove every Npm.require remaining
  • Correct typo for ReportCommon

@serut serut closed this Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants