Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
instrumentClientJs
action to mock the request and inject the instruments to the content.Description
This way leaves the finding of data off to the actual handler and just tip in when the response-object receives data. This data then is decompressed if necessary and the instruments are injected.
Motivation and Context
The main motivation was the rewrite of the package
dynamic-import
which (by an update to Meteor 1.6.1) has switched over to use HTTP requests instead of a Meteor method to request the new data. This way here provides a clean way to hook on to this method and inject the instruments.I haven't included a parser yet that would parse the
/__meteor__/dynamic-import/fetch
requests. I'll do this as soon as I got my project running on Meteor1.6.1
but this is a huge step forward to this, I believe.See: https://github.com/meteor/meteor/blob/devel/packages/dynamic-import
How Has This Been Tested?
Start the coverage on the client and confirm that the js-files build up the coverage-report
Screenshots (if appropriate):
Types of changes