Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wiki article needs updated #168

Closed
kim3-sudo opened this issue Dec 16, 2022 · 0 comments
Closed

Wiki article needs updated #168

kim3-sudo opened this issue Dec 16, 2022 · 0 comments

Comments

@kim3-sudo
Copy link
Contributor

The wiki article detailing installation needs to be updated. Support for empty() to determine the fullness of constants was not added until 5.5.

empty() to determine fullness of constants is needed for ./admin, specifically in line 42.

DEFINE("CRON_SERVER_IP", $db -> getSetting($mysqli, "cron_server_ip"));
if( empty(CRON_SERVER_IP)) {

is not valid in PHP 5.4, since CRON_SERVER_IP is defined as a constant and empty() cannot be used with a constant.
kim3-sudo added a commit to kim3-sudo/server-status that referenced this issue Dec 20, 2022
@kim3-sudo
Update minimum version to PHP5.5
9951c22 
This version is not compatible with PHP 5.4 due to a constants handling issue. See [GH issue server-status-project#168](server-status-project#168)
@kim3-sudo kim3-sudo mentioned this issue Dec 20, 2022
Merged
@Pryx Pryx closed this as completed in b2baa50 Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kim3-sudo