Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package installation. #85

Open
josephjohansson opened this issue Nov 23, 2017 · 1 comment
Open

Package installation. #85

josephjohansson opened this issue Nov 23, 2017 · 1 comment

Comments

@josephjohansson
Copy link

Hi. You guys have done some amazing work with this plugin. Its so useful! One big limitation that I quickly ran into with this package however is that there is no way to specify what custom packages from pip or npm can be installed into the docker lambda before the container and the code are executed. It would be great if there was a step where the code would parse a requirements.txt or package.json and install the requirements in the container before running. This way we could have non default packages in order to enable the true power of lambda. In the cloud version of lambda we can upload the packages using tools like serverless-python-requirements and invoke packages like elasticsearch in order to work with AWS ES. This plugin should enable me to do the same.

@josephjohansson
Copy link
Author

josephjohansson commented Feb 1, 2018

So this issue was resolved in a very dirty and hacky way and I think there is value in fleshing out a solution that works automatically with this plugin. See how I worked around this on this issue thread.

I think that this plugin should be able to build docker images with the packages we specify in requirements.txt or package.json automatically. I think we should either keep this issue open or open another one to implement something that automatically creates docker images and runs them. I think we need this because when I implement the hacky solution below I have to set the runtime in serverless.yml to something that is not part of the default runtimes. This means that there might be issues when running serverless deploy or you will have to change the yml file before you deploy. I don't think this is a viable solution. I am open to suggestions on how to implement this.

@jamespegg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant