-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Fastly Compute@Edge #108
Conversation
I've ran godnsbench however it errors on this application on line - https://github.com/ameshkov/godnsbench/blob/0994faab57033dbd27a9dd0feec18d269db61aeb/main.go#L301
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Unrelated to Fastly. Might be something else that's going wrong. I'll take a look. Also: Does Fastly support Cache Web APIs? Btw, |
Not yet, when we add support for the Cache Web API I will come back add turn it on for serverless-dns
Silly me 😅 |
Thanks for these code changes. I'm sure it must not have been an easy task to wade through this soup of a code :) Appreciate it.
Looking forward to it. I noticed from one of your tweets that Fastly has a Object Store now, which can be used to host the compressed trie blobs (which contains over 190+ blocklists). serverless-dns also uses Cloudflare LogPush and Workers Analytics. May be Fastly would have those someday too. Exciting times (: |
It could definitely store those, where are they currently stored? If stored in Object Store, it would be very fast reads from Fastly Compute@Edge |
They are uploaded to R2 (triggered by a scheduled GitHub Action every 8th day of the month) by: And retrieved from serverless-dns/src/core/env.js Lines 97 to 100 in 5d93c57
In the recent versions, we also downloadn a Geo IP database from R2: serverless-dns/src/core/env.js Lines 139 to 142 in 5d93c57
|
This adds support for Fastly's Compute@Edge platform and includes a fastly.toml with default values, which anyone can use to deploy to their Fastly account via☺️
fastly compute publish
. That's the only command they would nede to runWhen working on this, I found
pre.sh
would not run on OS X, I have modified the script to be compatible with OS X when the script is running on OS X 👍Please let me know if you have any questions or feedback for this work