Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deno-deploy.yml #124

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Update deno-deploy.yml #124

merged 1 commit into from
Jan 18, 2023

Conversation

dns-deploy
Copy link
Contributor

@dns-deploy dns-deploy commented Jan 18, 2023 •
edited

Fix deno-deploy.yml file

@dns-deploy
Update deno-deploy.yml
9c6ffd5 
Fix typo problem
@dns-deploy
Copy link
Contributor Author

the old deno-deploy.yml caused problem due to false deployctl version: " Error: Unable to resolve action denoland/deployctl@v1.4.0, unable to find version v1.4.0 "

@SpencerIsGiddy
Copy link
Contributor

the old deno-deploy.yml caused problem due to false deployctl version: " Error: Unable to resolve action denoland/deployctl@v1.4.0, unable to find version v1.4.0 "

What if you have it so it’s just v1 and not v1.4.0? I learned that v1 and v1.4.0(for example) point to the same version. Does it pop up with an error still?

@dns-deploy
Copy link
Contributor Author

I'd changed

the old deno-deploy.yml caused problem due to false deployctl version: " Error: Unable to resolve action denoland/deployctl@v1.4.0, unable to find version v1.4.0 "

What if you have it so it’s just v1 and not v1.4.0? I learned that v1 and v1.4.0(for example) point to the same version. Does it pop up with an error still?

image

@dns-deploy
Copy link
Contributor Author

https://deno.land/x/deploy@1.4.0

@SpencerIsGiddy
Copy link
Contributor

https://deno.land/x/deploy@1.4.0

Oh I see now👍

@ignoramous ignoramous merged commit 2a51fee into serverless-dns:main Jan 18, 2023
@ignoramous
Copy link
Contributor

Thanks. I was too lazy to fix this myself (:

@dns-deploy dns-deploy deleted the patch-2 branch January 19, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dns-deploy @SpencerIsGiddy @ignoramous