Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master CF stack name convention #127

Closed
stormit-vn opened this issue Aug 4, 2018 · 3 comments · Fixed by #156
Closed

Master CF stack name convention #127

stormit-vn opened this issue Aug 4, 2018 · 3 comments · Fixed by #156

Comments

@stormit-vn
Copy link

By the default, when we deploy the first version without alias option, the plugin creates a master CF stack name with suffix is (dev) i.e. sls-test-project-dev, also APIG is creating with dev prefix i.e. dev-sls-test-project. Is that possible to not adding suffix/prefix to APIG and Master CF stacks?

image

image

In fact, we only want to just create a master CF for the serverless with the name that we named in the serverless.yml (e.g. sls-test-project), also APIG name should the same. Adding prefix to APIG will make us confused that we will have more APIGs to be created for the same project which will never happen when using this plugin.

@stormit-vn
Copy link
Author

@HyperBrain Do you have any idea to update the stack names?

@johnwongapi
Copy link

+1.
We can config stackName for CF stack in serverless. But seems cannot customize APIG name in this plugin? please correct me if i am wrong

@aleksdikanski
Copy link

Hi @stormit-vn and @johnwongapi

I created PR #156 that would allow setting the master alias upon first deployment using sls deploy --masterAlias <masterAliasName>. Could you please check if this satisfies your requirements? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants