Skip to content

Commit

Permalink
Merge pull request #524 from Enase/dependencies
Browse files Browse the repository at this point in the history
Project dependencies updated
  • Loading branch information
HyperBrain committed Aug 27, 2019
2 parents 2139384 + 6601a1d commit ffb1a5b
Show file tree
Hide file tree
Showing 6 changed files with 3,757 additions and 4,132 deletions.
1 change: 1 addition & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,4 @@ rules:
lodash/preferred-alias: off
lodash/prop-shorthand: off
lodash/prefer-lodash-method: [ error, { ignoreObjects: [ BbPromise, path ] } ]
max-len: [ error, { code: 120, ignoreStrings: true, ignoreComments: true, ignoreTemplateLiterals: true } ]
9 changes: 4 additions & 5 deletions .lintstagedrc.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
linters:
"*.js":
- "prettier-eslint --write" # Run Prettier
- "eslint" # Run TSLint
- "git add"
"*.js":
- "prettier-eslint --write" # Run Prettier
- "eslint" # Run TSLint
- "git add"
8 changes: 2 additions & 6 deletions lib/packExternalModules.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,18 +127,14 @@ function getProdModules(externalModules, packagePath, dependencyGraph, forceExcl
if (!_.includes(ignoredDevDependencies, module.external)) {
// Runtime dependency found in devDependencies but not forcefully excluded
this.serverless.cli.log(
`ERROR: Runtime dependency '${
module.external
}' found in devDependencies. Move it to dependencies or use forceExclude to explicitly exclude it.`
`ERROR: Runtime dependency '${module.external}' found in devDependencies. Move it to dependencies or use forceExclude to explicitly exclude it.`
);
throw new this.serverless.classes.Error(`Serverless-webpack dependency error: ${module.external}.`);
}

this.options.verbose &&
this.serverless.cli.log(
`INFO: Runtime dependency '${
module.external
}' found in devDependencies. It has been excluded automatically.`
`INFO: Runtime dependency '${module.external}' found in devDependencies. It has been excluded automatically.`
);
}
}
Expand Down
4 changes: 1 addition & 3 deletions lib/validate.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ module.exports = {
if (_.isEmpty(files)) {
// If we cannot find any handler we should terminate with an error
throw new this.serverless.classes.Error(
`No matching handler found for '${fileName}' in '${
this.serverless.config.servicePath
}'. Check your service definition.`
`No matching handler found for '${fileName}' in '${this.serverless.config.servicePath}'. Check your service definition.`
);
}

Expand Down
Loading

0 comments on commit ffb1a5b

Please sign in to comment.