Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
v2.2.0 -> v2.2.1 broke my deployment workflow #202
This is a (Bug Report / Feature Proposal)
email@example.com (and all versions before):
No handler.js, and all functions relying on webpack don't work anymore.
For bug reports:
For feature proposals:
Similar or dependent issue(s):
handler: yes, matching
No, I don't see that warning in either version.
Ok. The only difference between 2.2.0 and 2.2.1 is the warning message to prevent a crash in case the handler entry is not parseable or not set (see git diff). There was no change in any of the other parts of the code.
I'm not sure where the changes you experience come from. What is strange is, that your chunk name is named
WAIT: I think the default output filename might have changed to [name].js to adapt the automatic entry point behavior! Before it used handler.js as fixed name, which is not flexible. Sorry for that - seems that commit was not published with 2.2.0 which it should have been.
What you can do is to add an explicit output configuration in your webpack config like this:
Or you switch to webpack 2 or webpack 3 and use the automatic entry detection with slsw.lib.entries that will automatically set up things for you.
@bebbi Ok. Thanks for the feedback. I'm not sure if I should revert the default output settings as 2.2.1 is only a bugfix release and should not change behavior or lead to failing builds. What is your opinion on that?
Looking in more detail at the diff 2.2.0 -> 2.2.1, it looks like there is a change in behaviour. It is introduced by this diff
where in 2.2.0,
Whereas in 2.2.1, I haven't debugged what is name but it most likely is the chunk name, i.e.
It would probably be easiest to simply fix this part in a 2.2.2 if that's possible.