Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark plugin as Serverless Framework v3 compliant #1016

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Nov 30, 2021

Plugin as is, will work with Serverless Framework v3 without issues, therefore it'll be great to mark it as compliant (so it doesn't report a lack of compatibility once v3 is released)

For complete adaptation, it'll be great if it also comes with modern logs (addressed at #1013)

@j0k3r j0k3r merged commit 2776bcf into serverless-heaven:master Dec 1, 2021
@j0k3r j0k3r added this to the 5.7.0 milestone Dec 1, 2021
@medikoo
Copy link
Contributor Author

medikoo commented Jan 6, 2022

@j0k3r when we can expect it to be published? We're aiming to release v3 soon, and without it users will be informed that plugin is not compatible with a new version

@j0k3r
Copy link
Member

j0k3r commented Jan 6, 2022

Sadly there is no so much we can do.
#1013 is blocked because coverage dropped (we understand why and it's ok) but it's required to merge.
I can't change it, only @HyperBrain have the right to do it.
I've requested him to remove that requirement so we can merge but so far, he's pretty silent.

@medikoo
Copy link
Contributor Author

medikoo commented Jan 26, 2022

@j0k3r can we have it PR published without #1013?

This plugin is perfectly runnable in v3 without new logs, and not publishing bumped version range in peerDependencies will leave false information to users that the plugin is not compatible, which is not the case.

@medikoo medikoo deleted the patch-1 branch January 26, 2022 13:45
@j0k3r
Copy link
Member

j0k3r commented Jan 26, 2022

All right, I'll release 5.6.1!

@j0k3r j0k3r modified the milestones: 5.7.0, 5.6.1 Jan 26, 2022
@j0k3r j0k3r mentioned this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants