Allow param values in slsw.lib.options
#1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newly added param value is typed as a string array, see serverless/serverless#9817
j0k3r
approved these changes
Mar 24, 2022
vicary
approved these changes
Mar 24, 2022
j0k3r
changed the title
slsw.lib.options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Serverless Framework v3.3 accepts multiple param options, see serverless/serverless#9817.
These are presented in options as a string array, which is incompatible with the previous definition of CLI options included in serverless-webpack.
How did you implement it:
I modified the typings so I can use
slsw.lib.options.param.include('xxxx')in my webpack.config.ts file.How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO