Fix this.serverless is undefined during zip
#1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicary
reviewed
May 9, 2022
j0k3r
force-pushed
the
fix/this-serverless-undefined-zip
branch
from
39d38d9
to
c0d8c4d
Compare
vicary
approved these changes
May 9, 2022
There was a problem hiding this comment.
LGTM, let's see if @3alqassab @rizowski has follow ups on #1140.
|
This fixed my initial issue. I am receiving a different error but I don't believe it is related. LGTM |
Calling `serverlessZip` directly does not _inject_ (or hydrate) the `this` inside the `serverlessZip`. We need to use `.call` for that.
j0k3r
force-pushed
the
fix/this-serverless-undefined-zip
branch
from
c0d8c4d
to
c34dbdc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
serverlessZipdirectly does not inject (or hydrate) thethisinside theserverlessZip.We need to use
.callfor that.Fix #1140