Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding missing optional peer deps #1287

Conversation

john-arccos
Copy link
Contributor

What did you implement:

Updated optional peer dependencies to fix warnings

Closes #XXXXX - didn't make a ticket, pretty straight forward.

This screenshot sums up the issue pretty nicely. yarn link is using my changes, yarn unlink is using the version from npm:
Screen Shot 2022-11-21 at 3 02 24 PM

How did you implement it:

How can we verify it:

If you have a project that's using serverless-webpack typescript, and ts-node, you'll see this warning appear when you install it. If you use my branch instead, the warning goes away.

Todos:

  • [N/A?] Write tests
  • [N/A?] Write documentation
  • [N/A] Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: It shouldn't be. Added two * optional peer dependencies and optional peer @typescript@>=2.0, which was already a requirement of ts-node. I guess if they have typescript 1.X but don't have ts-node it would be breaking? Not sure how you want to classify that. Alternatively, changing it to * would mean it's definitely non-breaking.

@j0k3r j0k3r requested a review from vicary November 22, 2022 08:06
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, thanks!

Copy link
Member

@vicary vicary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@j0k3r j0k3r force-pushed the bugfix/add-missing-optional-peer-dep branch from 221fa48 to c6a0dee Compare November 22, 2022 08:20
@j0k3r j0k3r enabled auto-merge November 22, 2022 08:23
@j0k3r j0k3r merged commit be66e95 into serverless-heaven:master Nov 22, 2022
@j0k3r j0k3r mentioned this pull request Nov 22, 2022
@j0k3r j0k3r added this to the 5.11.0 milestone Nov 22, 2022
@john-arccos john-arccos deleted the bugfix/add-missing-optional-peer-dep branch November 22, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants