Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to fix sample config. #265

Merged
merged 2 commits into from Oct 31, 2017
Merged

Update README.md to fix sample config. #265

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce7ae24
Update README.md
thepont Oct 30, 2017
470a744
Change filename in README example
Oct 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -132,12 +132,13 @@ for best compatibility with external dependencies:

```js
// webpack.config.js
const path = require('path');

module.exports = {
// ...
output: {
libraryTarget: 'commonjs',
path: '.webpack',
path: path.resolve(__dirname, '.webpack'),
filename: 'handler.js', // this should match the first part of function handler in `serverless.yml`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 3.x.x the filename should also be defined as [name].js so that it can be used with automatic entry resolution, which is now the preferred way to set the entries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it right now - ready to merge 😄

},
// ...
Expand Down