Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invocation of the async self-calling function #429

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fix invocation of the async self-calling function #429

merged 1 commit into from
Apr 10, 2019

Conversation

grgur
Copy link
Contributor

@grgur grgur commented Jul 30, 2018

What did you implement:

Needed an extra set of parenthesis around the async arrow function to be properly auto-invoked

How did you implement it:

Fixed readme example

How can we verify it:

N/A

Todos:

  • N/A Write tests
  • Write documentation
  • N/A Fix linting errors
  • N/A Make sure code coverage hasn't dropped
  • N/A Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Needed an extra set of parenthesis around the async arrow function to be properly auto-invoked
@designfrontier designfrontier added this to the 5.3.0 milestone Apr 10, 2019
@designfrontier designfrontier self-assigned this Apr 10, 2019
@designfrontier
Copy link
Contributor

Thanks for sending this fix to the documentation!

@designfrontier designfrontier merged commit 3240cce into serverless-heaven:master Apr 10, 2019
@grgur grgur deleted the patch-1 branch April 12, 2019 07:23
@HyperBrain HyperBrain mentioned this pull request Apr 30, 2019
@HyperBrain
Copy link
Member

Released with 5.3.0

jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
Fix invocation of the async self-calling function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants