Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invocation of the async self-calling function #429

Merged
merged 1 commit into from Apr 10, 2019

Conversation

@grgur
Copy link
Contributor

commented Jul 30, 2018

What did you implement:

Needed an extra set of parenthesis around the async arrow function to be properly auto-invoked

How did you implement it:

Fixed readme example

How can we verify it:

N/A

Todos:

  • N/A Write tests
  • Write documentation
  • N/A Fix linting errors
  • N/A Make sure code coverage hasn't dropped
  • N/A Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Fix invocation of the async self-calling function
Needed an extra set of parenthesis around the async arrow function to be properly auto-invoked

@designfrontier designfrontier added this to the 5.3.0 milestone Apr 10, 2019

@designfrontier designfrontier self-assigned this Apr 10, 2019

@designfrontier

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Thanks for sending this fix to the documentation!

@designfrontier designfrontier merged commit 3240cce into serverless-heaven:master Apr 10, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.09%
Details

@grgur grgur deleted the grgur:patch-1 branch Apr 12, 2019

@HyperBrain HyperBrain referenced this pull request Apr 30, 2019
@HyperBrain

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Released with 5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.