Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another implementation for compatibility with serverless-offline #58

Merged
merged 1 commit into from Dec 23, 2016

Conversation

rvaidya
Copy link
Contributor

@rvaidya rvaidya commented Nov 17, 2016

Replaces #55, #49, #47

This runs webpack.watch rather than webpack.compile for developer sanity reasons.

@rvaidya
Copy link
Contributor Author

rvaidya commented Nov 17, 2016

You may want to edit the implementation for semantics, I'm using the name "wpwatch" since "watch" is taken by the "webpack watch" function.

@rvaidya
Copy link
Contributor Author

rvaidya commented Nov 17, 2016

One note for serverless-offline, right now the entry point is hardcoded to ./handler.js

Webpack's output file must be generated in the project base directory for now, until specifying an input directory is added in serverless-offline

serverless-offline picks up all js files in the base dir as potential routes that can be referenced in serverless.yml

Referenced serverless-offline issue dherault/serverless-offline#153

@miltador
Copy link

miltador commented Nov 21, 2016

@rvaidya, nice!
I think you can remove the offline part now and the old watch, serve, invoke commands according to discussing in #56 so that we'll leave the service emulation to the serverless-offline plugin.

dherault/serverless-offline#153 is merged, so now it can be started with --location .webpack.

@mhodgson
Copy link
Contributor

👍 LGTM

@thenikso
Copy link
Contributor

thenikso commented Dec 20, 2016

hello everyone! sorry for my absence! in the coming days I'll work on addressing all the opened PRs and issues starting with this one.

Is this preferred to #55 and the like? also is there some unit test that we should add for the new function?

@mhodgson
Copy link
Contributor

@thenikso yes I've been using this for a while and it works well.

@thenikso thenikso merged commit b047cb0 into serverless-heaven:master Dec 23, 2016
@ghost
Copy link

ghost commented Jan 22, 2017

I feel that webpack serve should be removed and ppl should rely on serverless-offline for local testing, just focus only the webpack part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants