Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/5.3.3 #605

Merged
merged 28 commits into from Jul 23, 2020
Merged

Release/5.3.3 #605

merged 28 commits into from Jul 23, 2020

Conversation

miguel-a-calles-mba
Copy link
Member

What did you implement:

Releasing 5.3.3

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

stevemao and others added 25 commits May 20, 2019 13:19
completely turn off the NodeStuffPlugin and NodeSourcePlugin plugins.

We don't want webpack to mock node globals

See https://codeburst.io/use-webpack-with-dirname-correctly-4cad3b265a92 and https://webpack.js.org/configuration/node
webpack should not try to load handlers of different runtime than node.
default webpackConfig.node should be false
When fetching peer dependencies we now remove those which are optional.
And optional dependencies can be defined using Yarn (only at the moment) when using the `peerDependenciesMeta` field.
Fix `yarn list --json` stdOut parsing. fixes #388
From: Add support for multiple runtimes in service #530
Check for node runtimes first
Mostly to includes a security fix.
See GHSA-p6mc-m468-83gw

Also:
- add node 12 on Appveyor
- update Travis config file to fix validation
- rename `.eslintrc` file to add `.yml` extension (and allow syntax highlighting)
@miguel-a-calles-mba miguel-a-calles-mba requested a review from a team July 21, 2020 15:29
README.md Outdated
@@ -756,6 +756,33 @@ me to take it over and continue working on the project. That helped to revive it

## Release Notes

* 5.3.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of writing change log inside the readme, we should create a dedicated file CHANGELOG.md?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion. I added it.

@miguel-a-calles-mba miguel-a-calles-mba added this to the 5.3.3 milestone Jul 23, 2020
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miguel-a-calles-mba miguel-a-calles-mba merged commit ad61d7a into master Jul 23, 2020
@miguel-a-calles-mba miguel-a-calles-mba deleted the release/5.3.3 branch July 23, 2020 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants